Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename compute task status #188

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 19, 2024

Related issue

Companion PR Substra/substra#399

Summary

Notes

Please check if the PR fulfills these requirements

  • If the feature has an impact on the user experience, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification

@SdgJlbl SdgJlbl requested a review from a team as a code owner February 19, 2024 08:18
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 19, 2024

/e2e --help

@Owlfred
Copy link

Owlfred commented Feb 19, 2024

Usage: /e2e [options] [help]

/e2e may appear anywhere as long as it is on its own line

Options:
  --refs <value>                          Extra refs (branch or tag) with format REPO=GIT_REF,REPO=GIT_REF.
  Supported repositories: orchestrator, substra-backend, substra-frontend, substra-tools, substrafl, substra, substra-tests, substra-documentation, substra-ci.
  Example: /e2e --refs substra-backend=some_branch,orchestrator=some_tag (default: {})
  --tests-to-run, --tests <tests-to-run>  Comma-separated list of tests to run. Valid options: sdk, substrafl, doc, frontend, mnist, camelyon or NONE. (default: "sdk")
  -h, --help                              display help for command

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 19, 2024

/e2e --tests substrafl,doc

@Owlfred
Copy link

Owlfred commented Feb 19, 2024

End to end tests: ❌ FAILURE

Jobs status:

It'll stay between us, no one needs to know.

@ThibaultFy
Copy link
Member

The examples also directly refer to from substra.sdk.models import Status (at least the substra core diabetes one).

Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx :)

@SdgJlbl SdgJlbl merged commit e77e190 into main Feb 19, 2024
7 checks passed
@SdgJlbl SdgJlbl deleted the chore/rename-compute-task-status branch February 19, 2024 09:05
ThibaultFy pushed a commit that referenced this pull request Feb 22, 2024
ThibaultFy pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants