fix(benchmark/camelyon): actually rely on gpu setup at Dependency level
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SdgJlbl
approved these changes
Sep 3, 2024
ThibaultFy
requested changes
Sep 3, 2024
| @@ -64,7 +64,7 @@ def fed_avg(params: dict, train_folder: Path, test_folder: Path): | |||
| mode=exp_params["mode"], | |||
| cp_name=exp_params["cp_name"], | |||
| cancel_cp=exp_params["cancel_cp"], | |||
| torch_gpu=exp_params["torch_gpu"], | |||
There was a problem hiding this comment.
This will break the CI, need to do a companion PR on test-release-dev.yaml
There was a problem hiding this comment.
Yes, this is identified, and it will be updated - but thanks for the reminder!
There was a problem hiding this comment.
ThibaultFy
reviewed
Sep 3, 2024
| @@ -108,6 +108,7 @@ def substrafl_fed_avg( | |||
| # Keeping editable_mode=True to ensure nightly test benchmarks are ran against main substrafl git ref | |||
| editable_mode=True, | |||
| compile=True, | |||
| use_gpu=use_gpu, | |||
There was a problem hiding this comment.
The renaming is not necessary, you can just set use_gpu=torch_gpu
There was a problem hiding this comment.
Yes, it was mainly for consistency through the workflow and to avoid having a third variable name for this. If you prefer keeping torch_gpu I can revert tho, I don't mind!
… level Signed-off-by: Thibault Camalon <[email protected]>
thbcmlowk
force-pushed
the
fix/camelyon-with-gpu
branch
from
03b2fa2 to
aff0f26
Compare
ThibaultFy
approved these changes
Sep 3, 2024
Signed-off-by: Thibault Camalon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#followed by the number of the issueSummary
Notes
Please check if the PR fulfills these requirements