feat: add the option to inject binary libraries to install in Dockerfile #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SdgJlbl
force-pushed
the
feat/configurable-bin
branch
3 times, most recently
from
202c451 to
e5190e4
Compare
ThibaultFy
reviewed
Oct 2, 2024
| @@ -64,6 +64,7 @@ class Dependency(BaseModel): | |||
| pypi_dependencies: List[str] = Field(default_factory=list) | |||
| local_installable_dependencies: List[Path] = Field(default_factory=list) | |||
| local_code: List[Path] = Field(default_factory=list) | |||
| binary_dependencies: List[str] = Field(default_factory=list) | |||
There was a problem hiding this comment.
Need to update the docstringss
| @@ -64,7 +64,7 @@ def test_get_base_docker_image_gpu(): | |||
| && apt-get install -y software-properties-common\ | |||
| && add-apt-repository -y ppa:deadsnakes/ppa\ | |||
| && apt-get -y upgrade\ | |||
| && apt-get install -y python3.11 python3.11-venv python3-pip\ | |||
| && apt-get install -y python3.11 python3.11-venv python3-pip \ | |||
There was a problem hiding this comment.
Suggested change
| && apt-get install -y python3.11 python3.11-venv python3-pip \ | |
| && apt-get install -y python3.11 python3.11-venv python3-pip\ |
There was a problem hiding this comment.
This whitespace is required to make the test pass, actually :)
There was a problem hiding this comment.
That's the place where the binary dependencies would be if there were defined
Signed-off-by: SdgJlbl <[email protected]>
SdgJlbl
force-pushed
the
feat/configurable-bin
branch
from
e5190e4 to
e96f1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FL-1741