chore: unpin NumPy to allow use of 2.0 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SdgJlbl <[email protected]>
|
/e2e --tests=sdk,mnist |
|
End to end tests: ✔️ SUCCESS Yay! 🎉 |
|
The pin was to prevent incompatibilities regarding pickle. What is the issue with it ? |
Keeping a pin to an old version of NumPy is going to be more and more problematic down the line, as more recent versions of pandas / pytorch might not support NumPy 1.x. If it's working with NumPy 2.x, I think we should allow it. Do you remember when the issue with pickle was occurring? |
guilhem-barthes
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-to-end tests here Substra/substra-documentation#441 (comment)