chore: update setuptools in docker images #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultFy
commented
Sep 30, 2024
| @@ -62,7 +62,7 @@ | |||
| ENV PATH="/home/user/venv/bin:$PATH" VIRTUAL_ENV="/home/user/venv" | |||
|
|
|||
| # install dependencies | |||
| RUN python{python_version} -m pip install -U pip | |||
| RUN python{python_version} -m pip install -U pip && pip install -U setuptools>=70.0.0 | |||
There was a problem hiding this comment.
Or we can just uninstall it...
There was a problem hiding this comment.
Not sure if it's not used when building wheels for some more exotic dependencies... :/
Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
ThibaultFy
force-pushed
the
chore/update-docker-setuptools-version
branch
from
b633ca0 to
516738d
Compare
Signed-off-by: ThibaultFy <[email protected]>
SdgJlbl
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#followed by the number of the issueSummary
Notes
Please check if the PR fulfills these requirements