Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker image template to work on AWS #256

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: docker image template to work on AWS #256

merged 1 commit into from
Oct 14, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Oct 11, 2024

Patch to make the generated Dockerfile compatible with kaniko behaviour on AWS

@SdgJlbl SdgJlbl requested a review from a team as a code owner October 11, 2024 14:55
@SdgJlbl SdgJlbl force-pushed the fix/image-template-for-aws branch from 85d3fcb to ca05fba Compare October 11, 2024 14:56
@SdgJlbl SdgJlbl force-pushed the fix/image-template-for-aws branch from ca05fba to 7c17050 Compare October 11, 2024 15:10
ThibaultFy
ThibaultFy approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chances that it impact the CVEs ?

@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Oct 14, 2024

Any chances that it impact the CVEs ?

it shouldn't, since the apt-get update was already done before (but it seems that the apt cache is flushed more often in AWS than in GCP, so we need to redo it before each command).

But then again, it's probably worth checking it again.

@SdgJlbl SdgJlbl merged commit 132f869 into main Oct 14, 2024
11 checks passed
@SdgJlbl SdgJlbl deleted the fix/image-template-for-aws branch October 14, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultFy ThibaultFy ThibaultFy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SdgJlbl @ThibaultFy