Skip to content

Commit

Permalink
Fix package reference positioning in Commas.csproj
Browse files Browse the repository at this point in the history
Reordered the `libse` package reference to align with best practices and added explanatory comments. These clarifications ensure better understanding of dependency management and runtime assembly resolution.
  • Loading branch information
ivandrofly committed Feb 15, 2025
1 parent 032c241 commit 2959ce0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions source/Commas/Commas.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="libse" IncludeAssets="compile"/>

<!-- https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets-->
<!-- Note: these nuget package are already part of the main app (Subtititle Edit) so we are only using them here to allow the plugin to compaile-->
<!-- https://learn.microsoft.com/en-us/dotnet/framework/deployment/how-the-runtime-locates-assemblies#locating-the-assembly-through-probing (runtime will find these assembly in Application base)-->
<PackageReference Include="libse" IncludeAssets="compile"/>
<PackageReference Include="Newtonsoft.Json" IncludeAssets="compile"/>
</ItemGroup>

Expand Down

0 comments on commit 2959ce0

Please sign in to comment.