Changes committed #470
Closed
Changes committed #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Keep the website name AgriLearnNetwork near the logo only as it is now. Also kindly attach a video to demonstrate the changes both in dark and light mode. Also can you change the symbol of the modes like this: |
|
@Shivam250702 are you working? |
|
I have pushed the changes you required kindly check |
|
Resolve the conflicts. Pull all changes from origin and add a video or screenshot to demonstrate how the website works both in dark and light mode. |
|
|
|
Resolve the conflicts. Pull all recent changes from origin |
|
In light mode you can keep some light shade of green. Make sure all the content is visible clearly whatever colour you choose. |
|
Also check the placement of the mode option in small devices |
|
Once you are done raise anothe PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
#213
Description
[Please include a brief description of the changes or features added]
Added the Dark mode feature on Navbar
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Additional context:
[Include any additional information or context that might be helpful for reviewers.]