docs: refactor installation guide #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
docs/installation
branch
10 times, most recently
from
bb62454 to
8efc0a6
Compare
swiatekm
force-pushed
the
docs/installation
branch
3 times, most recently
from
02b06e0 to
0866573
Compare
|
|
||
| ## Uninstalling Sumo Logic Collection | ||
| - `kubectl delete job -n ${NAMESPACE} my-release-sumologic-setup` |
There was a problem hiding this comment.
why do we need to delete the job explicitly, isn't the job/pod removed once its complete?
There was a problem hiding this comment.
It is after some TTL (https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/), but this isn't guaranteed to have passed at this point.
|
|
||
| ## Uninstalling Sumo Logic Collection | ||
| - `kubectl delete job -n ${NAMESPACE} my-release-sumologic-setup` | ||
| - `kubectl delete job -n ${NAMESPACE} my-release-sumologic-ot-operator-instr` (needed only if `opentelemetry-operator.enabled=true`) |
There was a problem hiding this comment.
same question here I guess.
|
|
||
|  | ||
|
|
||
| [sumo-k8s-app-dashboards]: https://help.sumologic.com/docs/integrations/containers-orchestration/kubernetes#installing-the-kubernetes-app |
There was a problem hiding this comment.
nice looking dashboard!
| containers: | ||
| otelcol: | ||
| securityContext: | ||
| privileged: true |
There was a problem hiding this comment.
is this privilege elevation only required in openshift?
There was a problem hiding this comment.
I believe so, but I'm not an expert on OpenShift. @kkujawa-sumo do you know?
rnishtala-sumo
approved these changes
Oct 17, 2023
swiatekm
force-pushed
the
docs/installation
branch
from
0866573 to
a533236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the installation guide more streamlined, mostly by making the critical path as short and straightforward as possible, and moving less used sections to later parts of the document.
Some more specific changes:
Checklist