feat: allow setting the cluster DNS domain #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
force-pushed
the
fix/cluster-dns
branch
from
1eec710 to
0b3dec3
Compare
We use cluster.local by default to speed up DNS resolution, but this doesn't work in clusters with a custom domain. The Prometheus remote write domain doesn't use the suffix because there isn't any way to modify it from values.yaml other than manually.
swiatekm
force-pushed
the
fix/cluster-dns
branch
from
0b3dec3 to
023ad70
Compare
swiatekm
changed the title
andrzej-stencel
approved these changes
Oct 27, 2023
sumo-drosiek
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to change the domain from the default
cluster.localusing KOPS or Kubespray, or just kubeadm directly. In that case, our endpoints won't resolve correctly. There's reasons to use the fully qualified names whenever possible, so I'm adding a setting for the cluster DNS domain for users who actually set a custom one.There's no straightforward way to replace this for Prometheus remote write urls, so I've just removed the suffix completely. Given that Prometheus is slowly on the way out and not the default in v4, this should be fine.
See for reference on why we bother with this: #2502 kubernetes/kubernetes#56903 (comment)
Checklist