fix: rely on api rather than on k8s version #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@montmanu Please review as the original PR was from you 🙏 |
andrzej-stencel
approved these changes
Oct 31, 2023
swiatekm
approved these changes
Oct 31, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-v3 release-v3
# Navigate to the new working tree
cd .worktrees/backport-release-v3
# Create a new branch
git switch --create backport-3366-to-release-v3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a6fb9703679555774a5bef44630a7d308b2476b0
# Push it to GitHub
git push --set-upstream origin backport-3366-to-release-v3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-v3Then, create a pull request where the |
sumo-drosiek
added a commit
that referenced
this pull request
Oct 31, 2023
* use autoscaling/v2 if available on the cluster * add changelog entry * Rename 3315.fixed.txt to 3366.fixed.txt --------- Co-authored-by: Christopher Montoro <[email protected]> (cherry picked from commit a6fb970)
sumo-drosiek
added a commit
that referenced
this pull request
Oct 31, 2023
* use autoscaling/v2 if available on the cluster * add changelog entry * Rename 3315.fixed.txt to 3366.fixed.txt --------- Co-authored-by: Christopher Montoro <[email protected]> (cherry picked from commit a6fb970)
sumo-drosiek
added a commit
that referenced
this pull request
Oct 31, 2023
* use autoscaling/v2 if available on the cluster * add changelog entry * Rename 3315.fixed.txt to 3366.fixed.txt --------- Co-authored-by: Christopher Montoro <[email protected]> (cherry picked from commit a6fb970)
sumo-drosiek
added a commit
that referenced
this pull request
Oct 31, 2023
* fix: rely on api rather than on k8s version (#3366) * use autoscaling/v2 if available on the cluster * add changelog entry * Rename 3315.fixed.txt to 3366.fixed.txt --------- Co-authored-by: Christopher Montoro <[email protected]> (cherry picked from commit a6fb970) * Rename 3366.fixed.txt to 3367.fixed.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Adoption of @montmanu #3315