chore(instrumentation): update auto-instrumentation images #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
swiatekm
reviewed
Mar 5, 2024
deploy/helm/sumologic/README.md
Outdated
| @@ -283,19 +283,19 @@ The following table lists the configurable parameters of the Sumo Logic chart an | |||
| | `opentelemetry-operator.enabled` | Flag to control deploying OpenTelemetry Operator Helm sub-chart. | `true` | | |||
| | `opentelemetry-operator.createDefaultInstrumentation` | Flag to control creation of default Instrumentation object | `false` | | |||
| | `opentelemetry-operator.instrumentation.dotnet.extraEnvVars` | Additional environment variables for OpenTelemetry Operator Instrumentation Resource. | `{}` | | |||
| | `opentelemetry-operator.instrumentation.dotnet.image` | OpenTelemetry Operator DotNet Instrumentation image. | `ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-dotnet:0.7.0` | | |||
| | `opentelemetry-operator.instrumentation.dotnet.image` | OpenTelemetry Operator DotNet Instrumentation image. | `ghcr.io/open-telemetry/opentelemetry-operator/autoinstrumentation-dotnet:1.4.0` | | |||
There was a problem hiding this comment.
This is a major breaking change due to changes to HTTP semantic conventions. Shouldn't we hold back with it? At the very least, we should add a warning to the changelog about this.
There was a problem hiding this comment.
Good catch, I've mixed core vs instr versioning... I will revert to the previous version used. Lack of support on our side for new sem conv will be growing pain soon.
There was a problem hiding this comment.
I'm pretty sure 1.2.0 is the latest version without the semconv changes, so we can upgrade to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates auto-instrumentation images used by OpenTelemetry-Operator.
Checklist