Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade opentelemetry-operator Chart to 0.56.1 #3777

Merged
merged 1 commit into from
Jun 24, 2024
Merged

deps: upgrade opentelemetry-operator Chart to 0.56.1 #3777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/3777.changed.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
deps: upgrade opentelemetry-operator Chart to 0.56.1
2 changes: 1 addition & 1 deletion deploy/helm/sumologic/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ dependencies:
repository: https://sumologic.github.io/tailing-sidecar
condition: tailing-sidecar-operator.enabled
- name: opentelemetry-operator
version: 0.49.0
version: 0.56.1
repository: https://open-telemetry.github.io/opentelemetry-helm-charts
condition: opentelemetry-operator.enabled,sumologic.metrics.collector.otelcol.enabled
- name: prometheus-windows-exporter
Expand Down
4 changes: 1 addition & 3 deletions deploy/helm/sumologic/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2464,8 +2464,7 @@ opentelemetry-operator:

## Specific for OpenTelemetry Operator chart values
admissionWebhooks:
failurePolicy: Fail
enabled: true
create: true
Copy link
Contributor

@rnishtala-sumo rnishtala-sumo Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this change affect helm chart upgrades in anyway? What changes would we need in the helm chart after this version of the operator?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. If someone disabled webhooks, they'll get an error and will need to set create: false instead of create: true. The other values I removed because we were using defaults anyway.

Copy link
Contributor

@rnishtala-sumo rnishtala-sumo Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to CRD handling that will require changes on our end as well.

ok, what about the upcoming changes mentioned here. Is there a breaking change in the operator that we should be tracking to upgrade to the next version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator Helm Chart v0.57.0 moves CRDs to templates. This effectively makes it impossible for us to use them, as we need to create an OpenTelemetryCollector CR during installation. We should move this discussion to an issue if you want to go into details, as it's not really related to this PR.


## skip admission webhook on our own OpenTelemetryCollector object to avoid having to wait for operator to start
objectSelector:
Expand All @@ -2476,7 +2475,6 @@ opentelemetry-operator:

certManager:
enabled: false
issuerRef: {}

manager:
image:
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ The following table displays the currently used software versions for our Helm c
| Name | Version |
| ----------------------------------------- | ------- |
| OpenTelemetry Collector | 0.102.1 |
| OpenTelemetry Operator | 0.49.0 |
| OpenTelemetry Operator | 0.56.1 |
| kube-prometheus-stack/Prometheus Operator | 40.5.0 |
| Falco | 3.8.7 |
| Metrics Server | 6.11.2 |
Expand Down
Loading