Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scripts/build-push.sh #76

Merged
merged 7 commits into from
May 29, 2024
Merged

feat: add scripts/build-push.sh #76

merged 7 commits into from
May 29, 2024

Conversation

sumo-drosiek
Copy link
Contributor

No description provided.

Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner May 29, 2024 08:52

certify:
PUSH=true CERTIFY=true CHECK=false ./scripts/build-push-all.sh
PUSH=true CHECK=true CERTIFY=true ./scripts/build-push-all.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should check before certify

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the order here matter at all?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order is not important, it is only value of variable. I suspect that Dominik changed the order to have logical order of variables.

Dominik Rosiek added 4 commits May 29, 2024 11:07
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-single-check branch from 65dc3de to 11b8494 Compare May 29, 2024 10:16
Signed-off-by: Dominik Rosiek <[email protected]>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-single-check branch from 11b8494 to d42cf40 Compare May 29, 2024 10:18
@sumo-drosiek sumo-drosiek merged commit fd8f393 into main May 29, 2024
1 check passed
@sumo-drosiek sumo-drosiek deleted the drosiek-single-check branch May 29, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants