-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUMO-245309 Add the terraform support for Azure metric sources #710
Conversation
f59c28c
to
68ade3d
Compare
68ade3d
to
5397700
Compare
de76dfc
to
9ccf1a2
Compare
2a5c0b5
to
a10c426
Compare
a10c426
to
df9b4b0
Compare
9606f54
to
c0deeeb
Compare
@ErikAtSumo The current the unit test failure is about the azure event hub sources, which irrelevant with the changes in this PR. Can you please help to try to merge this PR? |
Hi @yuting-liu , I'll have a look now. |
@yuting-liu Indeed, these tests are also failing on master for the same reason. I'll merge this PR and figure it out separately. |
@yuting-liu would you please correct the conflict in CHANGELOG.md ? |
@ErikAtSumo I've already corrected the Changelog.md and put the new resource under |
In this PR, we added the terraform support for Azure metrics sources.
Changes
One thing to mention here for
TagFilters
field in Azure metrics sources, we added a newazure_tag_filters
instead of using the sametag_filters
as CloudWatch sources and kinesis metrics sources. The major reason is that fortags
, the schemas are different and it requires to have a detailed schema definition in terraform world, which is why we added this new field. And forazure_tag_filters
, we requiredtype = "AzureTagFilters"
to be required.Test
Tests / Matrix Test (1.0.3) (pull_request)
are not passing with the following error:The reason is that we need to ask the terraform team to help us to configure the following secrets for the test to run:
I'll work with the team on fixing it: slack: #terraform-team