-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Metrics V2 resource which uses V2 endpoints #720
Conversation
…der-sumologic into sukhdeep-MET-21556-newMetricsV2Resouce
the new test is failing
|
@sjain05 It is working fine when I am running the tests on my local. Do we know which enviroment do we use to run tests on PR builder? I would like to see what this error code says |
@sjain05 Might have been some intermittent issue. Passed on Retry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but please address the comments
couple of things -
|
|
Why this change?
Fixes issue: #713
The current metrics search resource is not compatible with V2 metrics searches. The UI has completely migrated to V2 metrics searches and resources created with v1 APIs are not compatible.
In order to fix this, we have provided support for metrics_searches_v2 which uses V2 endpoints for metrics searches resource creation.
API for reference:
https://help.sumologic.com/docs/api/metrics-searches-v2/
Testing performed:
The test cases sumologic/resource_sumologic_metrics_search_v2_test.go are run with one of the sumologic enviroments and I was able to verify the newly created resource is visible in the personal folder in the library. On opening the resource, all the details are correctly set.