fix a rare race condition

Sunbird-Obsrv · Jul 9, 2015 · 80d14e6 · 80d14e6
1 parent bc0cafe
commit 80d14e6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/main/java/com/pinterest/secor/uploader/Uploader.java b/src/main/java/com/pinterest/secor/uploader/Uploader.java
@@ -102,15 +102,15 @@ private void uploadFiles(TopicPartition topicPartition) throws Exception {
             topicPartition.getTopic(),
             topicPartition.getPartition());
 
-        // Deleting writers closes their streams flushing all pending data to the disk.
-        mFileRegistry.deleteWriters(topicPartition);
         mZookeeperConnector.lock(lockPath);
         try {
             // Check if the committed offset has changed.
             long zookeeperComittedOffsetCount = mZookeeperConnector.getCommittedOffsetCount(
                     topicPartition);
             if (zookeeperComittedOffsetCount == committedOffsetCount) {
                 LOG.info("uploading topic {} partition {}", topicPartition.getTopic(), topicPartition.getPartition());
+                // Deleting writers closes their streams flushing all pending data to the disk.
+                mFileRegistry.deleteWriters(topicPartition);
                 Collection<LogFilePath> paths = mFileRegistry.getPaths(topicPartition);
                 List<Future<?>> uploadFutures = new ArrayList<Future<?>>();
                 for (LogFilePath path : paths) {