Merge pull request pinterest#95 from yyejun/debug_log_fix

avoid message toString when debug not enabled
Sunbird-Obsrv · May 20, 2015 · 83d2b3f · 83d2b3f
2 parents bf0b6ab + b24f4ea
commit 83d2b3f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/java/com/pinterest/secor/reader/MessageReader.java b/src/main/java/com/pinterest/secor/reader/MessageReader.java
@@ -150,7 +150,7 @@ public Message read() {
         updateAccessTime(topicPartition);
         // Skip already committed messages.
         long committedOffsetCount = mOffsetTracker.getTrueCommittedOffsetCount(topicPartition);
-        LOG.debug("read message" + message);
+        LOG.debug("read message {}", message);
         exportStats();
         if (message.getOffset() < committedOffsetCount) {
             LOG.debug("skipping message message " + message + " because its offset precedes " +

diff --git a/src/main/java/com/pinterest/secor/writer/MessageWriter.java b/src/main/java/com/pinterest/secor/writer/MessageWriter.java
@@ -87,7 +87,7 @@ public void write(ParsedMessage message) throws Exception {
         		mFileExtension);
         FileWriter writer = mFileRegistry.getOrCreateWriter(path, mCodec);
         writer.write(new KeyValue(message.getOffset(), message.getPayload()));
-        LOG.debug("appended message " + message + " to file " + path.getLogFilePath() +
-                  ".  File length " + writer.getLength());
+        LOG.debug("appended message {} to file {}.  File length {}",
+                  message, path.getLogFilePath(), writer.getLength());
     }
 }