Merge pull request #336 from holashchand/issue-1031

[BUG]: Fixed template id required error for only qr code generation
Sunbird-RC · Jun 24, 2024 · 4842229 · 4842229
2 parents 9c09f34 + 6e98801
commit 4842229
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/services/credentials-service/src/credentials/credentials.controller.ts b/services/credentials-service/src/credentials/credentials.controller.ts
@@ -75,8 +75,8 @@ export class CredentialsController {
     const requestedTemplateId: string = req.headers['templateid'] as string;
     const externalTemplate: string = req.headers['template'] as string;
 
-    if (!requestedTemplateId && !externalTemplate && accept !== 'application/json')
-      throw new BadRequestException('Template id is required');
+    if (!requestedTemplateId && !externalTemplate && ['application/pdf', 'text/html'].indexOf(accept) > -1)
+      throw new BadRequestException('Template id or template is required');
     else if (!requestedTemplateId && !externalTemplate && accept === 'application/json')
       return this.credentialsService.getCredentialById(
         id,