chore: remove unnecessary warning

SundaeSwap-finance · Jul 25, 2024 · 82c229b · 82c229b
1 parent b26795b
commit 82c229b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 25 deletions.
diff --git a/packages/asset/src/AssetAmount.ts b/packages/asset/src/AssetAmount.ts
@@ -26,8 +26,6 @@ export class AssetAmount<T extends IAssetAmountMetadata = IAssetAmountMetadata>
   static readonly DEFAULT_FUNGIBLE_TOKEN_DECIMALS = 0;
   static INVALID_METADATA =
     "Cannot perform exchange calculation on an AssetAmount with no metadata.";
-  static INVALID_DECIMAL_WARNING =
-    "Cannot perform addition or subtraction on AssetAmounts with different decimals.";
 
   readonly metadata: T;
   readonly id: string;
@@ -94,19 +92,11 @@ export class AssetAmount<T extends IAssetAmountMetadata = IAssetAmountMetadata>
   }
 
   add = (rhs: AssetAmount): AssetAmount<T> => {
-    if (this.decimals !== rhs.decimals) {
-      // eslint-disable-next-line no-console
-      console.warn(AssetAmount.INVALID_DECIMAL_WARNING);
-    }
     return this.withAmount(this.amount + rhs.amount);
   };
   plus = this.add;
 
   subtract = (rhs: AssetAmount): AssetAmount<T> => {
-    if (this.decimals !== rhs.decimals) {
-      // eslint-disable-next-line no-console
-      console.warn(AssetAmount.INVALID_DECIMAL_WARNING);
-    }
     return this.withAmount(this.amount - rhs.amount);
   };
   minus = this.subtract;

diff --git a/packages/asset/src/__tests__/AssetAmount.test.ts b/packages/asset/src/__tests__/AssetAmount.test.ts
@@ -1,4 +1,4 @@
-import { beforeEach, describe, it, expect, spyOn } from "bun:test";
+import { beforeEach, describe, it, expect } from "bun:test";
 import { AssetAmount, IAssetAmountMetadata } from "../AssetAmount.js";
 import { AssetRatio } from "../AssetRatio.js";
 
@@ -101,13 +101,6 @@ describe("AssetAmount", () => {
       new AssetAmount(1000000, sixDecimals).add(new AssetAmount(5000000, 6))
         .amount,
     ).toEqual(6000000n);
-
-    const spyConsole = spyOn(global.console, "warn");
-    new AssetAmount(1000000, 0).add(new AssetAmount(5000000, 6));
-    expect(spyConsole).toHaveBeenCalledWith(
-      AssetAmount.INVALID_DECIMAL_WARNING,
-    );
-    spyConsole.mockReset();
   });
 
   it("should subtract values correctly", () => {
@@ -130,13 +123,6 @@ describe("AssetAmount", () => {
         new AssetAmount(5000000, 6),
       ).amount,
     ).toEqual(5000000n);
-
-    const spyConsole = spyOn(global.console, "warn");
-    new AssetAmount(10000000, 0).subtract(new AssetAmount(5000000, 6));
-    expect(spyConsole).toHaveBeenCalledWith(
-      AssetAmount.INVALID_DECIMAL_WARNING,
-    );
-    spyConsole.mockReset();
   });
 });