Add "Oracles" #50
Merged
Add "Oracles" #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quantumplation
commented
Mar 19, 2024
lib/calculation/record.ak
Outdated
| // access to the final state of the order | ||
| let remainder = input.value | ||
| |> value.add(ada_policy_id, ada_asset_name, -actual_protocol_fee) | ||
| |> value.add(policy.1st, policy.2nd, 1) |
There was a problem hiding this comment.
maybe rename policy, since it's more than just a policy ID?
Also, should we check that this is minted, rather than coming from somewhere else for some reason?
| fn(output) { | ||
| (0, True), | ||
| fn(output, state) { | ||
| let (oracle_minted_index, no_duplicates) = state | ||
| let qty = value.quantity_of(output.value, own_policy_id, oracle_name) |
There was a problem hiding this comment.
what happens if someone mints a token of a different name? do we care? maybe something like
expect [(name, amt)] = value.tokens(output.value, own_policy_id)
expect name == oracle_name
when amt is {
...
}
Quantumplation
force-pushed
the
pi/oracles
branch
from
9d7597c to
079171f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new order type that creates an authenticated UTXO containing the price of the order.
Note: we might want to change the datum structure to match something like an Orcfax or Charli3 datum, or add a "pass through" data field.