-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SUN-887] Initial joint values are read when the hardware interface starts #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built it, it works. Nice!
I have general concerns about how we keep this in sync with upstream (or is our fork so far evolved?) but that's a separate question to this PR. I asked on slack already :)
No idea why I can't tick the checkmarks on the PR description... maybe it's the recent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine how painful this was 🫂.
Check the comments and you're good to go.
Btw, I can't tick the checkboxes in the description, so something is wrong with the permissions I guess. |
Description
This PR adds code that reads joint state values from RWS before the hardware interface is started. It is important to note that the code introduced here does not make use of the existing RWS managers that would be available vie
abb_librws
because those are incompatible with RWS2.0. For the sake of not complicating things, I added a simple method that makes the HTTP GET request to the correct address to retrieve the joint values.Some reading material regarding the issue:
Test plan
The test plan revolves mainly around making sure everything builds. The functionality will be tested by me on the real robot. Some additional changes might come into place after the test are done. However, the bulk of the work is here.
Checklist for Reviewers
Reviewer 1: @fgrcar
Reviewer 2: @JenniferBuehler
Before a PR to this repo can get approved and merged, the following needs to be checked by both reviewers:
README.md
been updated, or not required?CHANGELOG
been updated?package.xml
,CMakeLists.txt
and/orsetup.py
were made.requirements.txt
,setup.py
andpackage.xml
- or: not applicable.