Skip to content

Commit

Permalink
chore: types & doc
Browse files Browse the repository at this point in the history
  • Loading branch information
nytamin committed Oct 20, 2023
1 parent 00e6045 commit 39e9204
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ _Internal changes, like typos or internal fixes to the json-schema are not liste

* New **GDDType**: `color-rrggbbaa` [PR #16](https://github.com/SuperFlyTV/GraphicsDataDefinition/pull/16)
* Version 1.0.0 of the [javascript npm library](https://www.npmjs.com/package/graphics-data-definition) is released.
* Optional properties `authorName` and `authorEmail` added, [PR #17](https://github.com/SuperFlyTV/GraphicsDataDefinition/pull/17)

## 2022-10-28

Expand Down
4 changes: 4 additions & 0 deletions lib/javascript-library/src/lib/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export interface GDDSchema extends GDDSchemaPropertyObject {
}
}
}
/** Name of the author. */
authorName?: string
/** Email to the author. */
authorEmail?: string
}

export type GDDSchemaProperty =
Expand Down
1 change: 1 addition & 0 deletions lib/unit-tests/__tests__/basic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ describe('Schema - Basic types', () => {
validateSchema({
type: 'object',
properties: {},
// @ts-expect-error number, instead of string
authorName: 123, // bad type
})
).toMatch(/not.*string/)
Expand Down

0 comments on commit 39e9204

Please sign in to comment.