-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few stuff and fix a few stuff #45
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
SuperLlama88888
commented
Jan 7, 2025
•
edited
Loading
edited
- Add hanging signs, banners (single colour), frogspawn, mangrove roots, resin clumps (OOPS), and texture variants, for vaults, trial spawners and cave vines.
- Fix models for signs, bamboo fences, doors, trapdoors, and lit redstone torches.
- Fix doors and double plants having a doubled item count in material lists.
- Remove hardcoded patches for redstone dust tints and double slabs in material lists. HoloPrint is now 100% data-driven!
- Fix bugs with the generate pack form reset buttons:
- Generate pack form reset buttons now display their intended message when pressed.
- The button to clear resource pack cache has a translatable reset message.
- Fix file inputs always being reset in Chrome, regardless of whether they were in the correct fieldset or not.
Actually quite simple
Finally got around to implementing something like arrays. I think I'll use this for colouring potions in cauldrons.
The textures are correct now, and open doors are rotated correctly; however, the hinge bit is always 0 on the lower door block so they always have the left hinge. This is very annoying.
AAAAH FORGOR RESIN CLUMP
Naturally-generated cave vines show the "head" texture at age 25, but placed cave vines can have age 25 despite having more cave vines underneath. Because of this, they currently show the "body" texture all the time. (Cave vines with berries are technically different blocks so they work as expected.)
- Redstone dust tints have been redone with the new arrays feature, and double slabs in materials list have been replaced with a generalised item count multiplication system. - Doors and double plants now also have their counts halved to make it more accurate.
The open eyeblossom had closed and had to be replaced.
- Generate pack form reset buttons now display their intended message when pressed. - The button to clear resource pack cache has a translatable reset message. - Fix file inputs always being reset in Chrome, regardless of whether they were in the correct fieldset or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.