Add trigger direction property to script trigger #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
reviewed
Aug 9, 2024
MatusGuy
requested changes
Aug 9, 2024
tobbi
force-pushed
the
scripttrigger_trigger_direction
branch
from
9c17696 to
eb6dce0
Compare
I could not reproduce this.
Added that in the latest commit. |
|
I just found something: We could technically move the code to the trigger base class and support directions for all available triggers. |
|
Good idea |
MatusGuy
requested changes
Jan 27, 2025
Comment on lines
+148
to
+184
| const float indicator_width = 2.0f; | ||
| const float indicator_length = 50.0f; | ||
| std::vector<Rectf> indicators; | ||
|
|
||
| Rectf left_indicator = Rectf(bbox.get_left() - indicator_length, | ||
| bbox.get_middle().y - indicator_width, | ||
| bbox.get_left(), | ||
| bbox.get_middle().y + indicator_width); | ||
|
|
||
| Rectf right_indicator = Rectf(bbox.get_right(), | ||
| bbox.get_middle().y - indicator_width, | ||
| bbox.get_right() + indicator_length, | ||
| bbox.get_middle().y + indicator_width); | ||
|
|
||
| Rectf up_indicator = Rectf(bbox.get_middle().x - indicator_width, | ||
| bbox.get_top() - indicator_length, | ||
| bbox.get_middle().x + indicator_width, | ||
| bbox.get_top()); | ||
|
|
||
| Rectf down_indicator = Rectf(bbox.get_middle().x - indicator_width, | ||
| bbox.get_bottom(), | ||
| bbox.get_middle().x + indicator_width, | ||
| bbox.get_bottom() + indicator_length); | ||
|
|
||
| if(m_trigger_direction == Direction::LEFT || m_trigger_direction == Direction::AUTO) | ||
| indicators.push_back(left_indicator); | ||
| if(m_trigger_direction == Direction::RIGHT || m_trigger_direction == Direction::AUTO) | ||
| indicators.push_back(right_indicator); | ||
| if(m_trigger_direction == Direction::UP || m_trigger_direction == Direction::AUTO) | ||
| indicators.push_back(up_indicator); | ||
| if(m_trigger_direction == Direction::DOWN || m_trigger_direction == Direction::AUTO) | ||
| indicators.push_back(down_indicator); | ||
|
|
||
| for(const auto& dir_indicator : indicators) | ||
| { | ||
| context.color().draw_filled_rect(dir_indicator, color, transparency, layer); | ||
| } |
There was a problem hiding this comment.
Can't you just draw these rectangles directly? And you don't need to draw 4 indicators if a direction isn't specified, it's already implied.
|
|
||
| context.color().draw_filled_rect(bbox, color, transparency, layer); | ||
|
|
||
| if (!Editor::is_active() || m_trigger_direction == Direction::NONE) |
There was a problem hiding this comment.
m_trigger_direction == Direction::NONE is never true. Is it?
Comment on lines
+121
to
+128
| if (object_bbox.get_left() < bbox.get_left()) | ||
| object_direction = Direction::LEFT; | ||
| if (object_bbox.get_right() > bbox.get_right()) | ||
| object_direction = Direction::RIGHT; | ||
| if (object_bbox.get_top() < bbox.get_top()) | ||
| object_direction = Direction::UP; | ||
| if (object_bbox.get_bottom() > bbox.get_bottom()) | ||
| object_direction = Direction::DOWN; |
There was a problem hiding this comment.
This algorithm doesn't look right. Is it possible to instead use the CollisionHit given in collision instead? You could save the direction to a member variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a direction property to script trigger:
"auto" means that the trigger can be triggered from all sides.
"left" means only from the left side, "right" only from the right side etc.