Editor comment #3181
Open
Editor comment #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
added
involves:editor
type:feature
category:code
status:needs-review
|
i get missing texture for the icon in the thingy |
|
fixed |
Frostwithasideofsalt
approved these changes
Jan 25, 2025
Alasdairbugs
approved these changes
Jan 25, 2025
Vankata453
reviewed
Jan 25, 2025
Vankata453
reviewed
Feb 3, 2025
Comment on lines
+91
to
+92
| for (auto& line : m_lines) | ||
| line.reset(); |
Comment on lines
+16
to
+17
| reader.get("x", m_col.m_bbox.get_left(), 0.f); | ||
| reader.get("y", m_col.m_bbox.get_top(), 0.f); |
There was a problem hiding this comment.
Already done by MovingObject constructor.
Comment on lines
+1
to
+2
| #ifndef EDITOR_COMMENT_HPP | ||
| #define EDITOR_COMMENT_HPP |
There was a problem hiding this comment.
Missing copyright header, and also, follow the include guard convention used throughout the source.
| explicit EditorComment(const ReaderMapping& reader); | ||
|
|
||
| virtual void draw(DrawingContext& context) override; | ||
| virtual void update(float dt_sec) override { MovingObject::update(dt_sec); } |
|
|
||
| private: | ||
| void refresh_comment(); | ||
| Color get_color(); |
There was a problem hiding this comment.
const (CV) qualifier can be added.
| private: | ||
| std::string m_comment; | ||
| std::vector<std::unique_ptr<InfoBoxLine>> m_lines; | ||
| }; |
There was a problem hiding this comment.
Add a non-copyable footer to this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The editor comment allows level designers to leave a note for themselves or other level designers collaborating on the same level. Similar to a code comment, it can be used to write to-do lists, fixmes, or notes.
This feature supports info box formatting, like what you'd see in the info block or the text scroller.
Testers: Please test all formatting features in the editor comment (of course), the info block, and the text scroller (via credits, I guess).
Use this as a reference for all formatting features:
supertux/src/supertux/info_box_line.cpp
Lines 67 to 87 in 79c6ee8