Skip to content

Commit

Permalink
Github Packages broke the release, let’s fix that.
Browse files Browse the repository at this point in the history
1. Remove vestigial Github from publishing block in `maven-publish.gradle`
2. Make app versions 1.0 + library version to minimize human error
3. Update CHANGELOG.adoc
4. Update release-process.adoc
  • Loading branch information
msgilligan committed Jan 5, 2022
1 parent 12a3b43 commit 8958c8c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ Released: 2022-01-04
* Micronaut Test (Spock) 3.0.5
* GitLab CI build now uses `openjdk-17-jdk`
* Travis CI build removed
* Remove vestigial (and problematic) references to Github Maven repos in `publishing` block in `maven-publish.gradle`
* Sample Apps are now version 1.4.0 and will henceforth be `1.0` plus the Supernaut.FX version.

== v0.3.1

Expand Down
8 changes: 8 additions & 0 deletions doc/release-process.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@
.. `./gradlew publishSite`
. Create GitHub Release

== Sample App Versions

* Sample app versions are `1.0` + the Supernaut.FX version
* Sample app versions are bumped when work on next release begins and _should_ never contain `-SNAPSHOT`.
* These differences are required by limitations of the `jpackage` process. (some tools require 1.0 or later, others forbid a `-SNAPSHOT` in the version string.)

NOTE:: We need to stop publishing sample apps to Maven repos.

== Updating Gradle Dependency Verification configuration

NOTE:: We are not using Dependency Verification yet, but we did try to use it.
Expand Down
4 changes: 2 additions & 2 deletions gradle.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
supernautVersion = 0.4.0
helloAppVersion = 1.1.7
testAppVersion = 1.1.7
helloAppVersion = 1.4.0
testAppVersion = 1.4.0
signJPackageImages = false

# Major (whole number) version of JDK to use for javac, jlink, jpackage, etc.
Expand Down
8 changes: 0 additions & 8 deletions gradle/maven-publish.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@ subprojects {
header(HttpHeaderAuthentication)
}
}
maven {
name = "SupernautAppGitHubPackages"
url = "https://maven.pkg.github.com/SupernautApp/SupernautFX"
credentials {
username = project.findProperty("supernaut.github.user") ?: System.getenv("GITHUB_ACTOR")
password = project.findProperty("supernaut.github.key") ?: System.getenv("GITHUB_TOKEN")
}
}
}
publications {
jar(MavenPublication) {
Expand Down

0 comments on commit 8958c8c

Please sign in to comment.