Cumulative (including other forks) enhancements proposal #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Breaking: Minimum Node.js version >=14 - Breaking: `graphql-subscriptions` >= 2.0.0 - Breaking: `graphql` 16.x; dropped support for 14.x 15.x - Changed from deprecated `tslint` to `eslint` - Upgraded vulnerable packages `nodemon`, `mocha`, `sinon`, `ts-node`
Merged
|
Merged with #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤝 @shahyar 's changes have been taken (PR: #37) as a basement.
✅ On top of them, the following have been added:
eslint-plugin-jsdoc,eslint-plugin-mocha,eslint-plugin-no-nulltestdirectory (srcis not "polluted", it's easier to prepare build, etc.) [opinionated but inspired by Angular 😁]engines.nodefrom v14 to v18 + reflect in ci/cd and local development (.nvmrc)graphql-subscriptionsto peer-dependenciesmocha,chai,chai-as-promised,nyc,sinonandsinon-chaiwithjestas a standalone testing solutionCould not test
"publishPath": "/lib"option ofrelease-it(don't have permissions), please--dry-runto check iflibdirectory is the only one that is going to be published as an npm package.