chore(deps): update dependency restsharp to v112 [security] #863

marvin-serp-bot · 2024-10-09T22:27:43Z

This PR contains the following updates:

Package	Type	Update	Change
RestSharp (source)	nuget	major	`110.2.0` -> `112.0.0`

GitHub Vulnerability Alerts

CVE-2024-45302

Summary

The second argument to RestRequest.AddHeader (the header value) is vulnerable to CRLF injection. The same applies to RestRequest.AddOrUpdateHeader and RestClient.AddDefaultHeader.

Details

The way HTTP headers are added to a request is via the HttpHeaders.TryAddWithoutValidation method: https://github.com/restsharp/RestSharp/blob/777bf194ec2d14271e7807cc704e73ec18fcaf7e/src/RestSharp/Request/HttpRequestMessageExtensions.cs#L32 This method does not check for CRLF characters in the header value.

This means that any headers from a RestSharp.RequestHeaders object are added to the request in such a way that they are vulnerable to CRLF-injection. In general, CRLF-injection into a HTTP header (when using HTTP/1.1) means that one can inject additional HTTP headers or smuggle whole HTTP requests.

PoC

The below example code creates a console app that takes one command line variable "api key" and then makes a request to some status page with the provided key inserted in the "Authorization" header:

using RestSharp;

class Program
{
    static async Task Main(string[] args)
    {
        // Usage: dotnet run <api key>
        var key = args[0];
        var options = new RestClientOptions("http://insert.some.site.here");
        var client = new RestClient(options);
        var request = new RestRequest("/status", Method.Get).AddHeader("Authorization", key);
        var response = await client.ExecuteAsync(request);
        Console.WriteLine($"Status: {response.StatusCode}");
        Console.WriteLine($"Response: {response.Content}");
    }
}

This application is now vulnerable to CRLF-injection, and can thus be abused to for example perform request splitting and thus server side request forgery (SSRF):

anonymous@ubuntu-sofia-672448:~$ dotnet RestSharp-cli.dll $'test\r\nUser-Agent: injected header!\r\n\r\nGET /smuggled HTTP/1.1\r\nHost: insert.some.site.here'
Status: OK
Response: <html></html>

The application intends to send a single request of the form:

GET /status HTTP/1.1
Host: insert.some.site.here
Authorization: <api key>
User-Agent: RestSharp/111.4.1.0
Accept: application/json, text/json, text/x-json, text/javascript, application/xml, text/xml
Accept-Encoding: gzip, deflate, br

But as the application is vulnerable to CRLF injection the above command will instead result in the following two requests being sent:

GET /status HTTP/1.1
Host: insert.some.site.here
Authorization: test
User-Agent: injected header!

and

GET /smuggled HTTP/1.1
Host: insert.some.site.here
User-Agent: RestSharp/111.4.1.0
Accept: application/json, text/json, text/x-json, text/javascript, application/xml, text/xml
Accept-Encoding: gzip, deflate, br

This can be confirmed by checking the access logs on the server where these commands were run (with insert.some.site.here pointing to localhost):

anonymous@ubuntu-sofia-672448:~$ sudo tail /var/log/apache2/access.log
127.0.0.1 - - [29/Aug/2024:11:41:11 +0000] "GET /status HTTP/1.1" 200 240 "-" "injected header!"
127.0.0.1 - - [29/Aug/2024:11:41:11 +0000] "GET /smuggled HTTP/1.1" 404 436 "-" "RestSharp/111.4.1.0"

Impact

If an application using the RestSharp library passes a user-controllable value through to a header, then that application becomes vulnerable to CRLF-injection. This is not necessarily a security issue for a command line application like the one above, but if such code were present in a web application then it becomes vulnerable to request splitting (as shown in the PoC) and thus Server Side Request Forgery.

Strictly speaking this is a potential vulnerability in applications using RestSharp, not in RestSharp itself, but I would argue that at the very least there needs to be a warning about this behaviour in the RestSharp documentation.

Release Notes

restsharp/RestSharp (RestSharp)

What's Changed

Fix null reference exception when disposing response content by @alexeyzimarev in https://github.com/restsharp/RestSharp/pull/2201
Add Version to RestRequest by @alexeyzimarev in https://github.com/restsharp/RestSharp/pull/2209
Reverted authenticators rename
Returned back Execute(request) without method

Full Changelog: restsharp/RestSharp@111.1.0...111.2.0

`v111.1.0`

Compare Source

`v111.0.0`

Compare Source

What's Changed

Support file uploading without multipart/form-data by @RomanSoloweow in https://github.com/restsharp/RestSharp/pull/2068
Use builtin methods to ConcurrentDictionary by @sensslen in https://github.com/restsharp/RestSharp/pull/2073
Added remaining overloads (PATCH, HEAD, OPTIONS, DELETE) by @alexeyzimarev in https://github.com/restsharp/RestSharp/pull/2050
Use encoded filename for FileNameStar (#2117) by @alexeyzimarev in https://github.com/restsharp/RestSharp/pull/2123
Added Option to add Interceptors on client level by @fseidl-bauradar in https://github.com/restsharp/RestSharp/pull/2118
Use case insensitive comparer by @softworkz in https://github.com/restsharp/RestSharp/pull/2146
Adjust serializer selection fallback procedure by @softworkz in https://github.com/restsharp/RestSharp/pull/2147
Set UserAgent as a default header parameter by @PetesBreenCoding in https://github.com/restsharp/RestSharp/pull/2157
Fixes OAuth1 signature with special characters (#2126, #1945) by @elia936 in https://github.com/restsharp/RestSharp/pull/2127
Set Version to generic RestResponse by @biasso in https://github.com/restsharp/RestSharp/pull/2199
Timeout as TimeSpan, Support custom request timeout by @RomanSoloweow in https://github.com/restsharp/RestSharp/pull/2078

New Contributors

@RomanSoloweow made their first contribution in https://github.com/restsharp/RestSharp/pull/2068
@mikebundy made their first contribution in https://github.com/restsharp/RestSharp/pull/2097
@Kurzyn made their first contribution in https://github.com/restsharp/RestSharp/pull/2116
@fseidl-bauradar made their first contribution in https://github.com/restsharp/RestSharp/pull/2118
@mavaddat made their first contribution in https://github.com/restsharp/RestSharp/pull/2151
@softworkz made their first contribution in https://github.com/restsharp/RestSharp/pull/2146
@PetesBreenCoding made their first contribution in https://github.com/restsharp/RestSharp/pull/2157
@elia936 made their first contribution in https://github.com/restsharp/RestSharp/pull/2127
@thompson-tomo made their first contribution in https://github.com/restsharp/RestSharp/pull/2180
@biasso made their first contribution in https://github.com/restsharp/RestSharp/pull/2199

Full Changelog: restsharp/RestSharp@110.2.0...111.0.0

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

github-actions · 2024-10-09T22:28:16Z

✒️ PR Title Commitlint - ✔️ Lint success!

marvin-serp-bot requested a review from jaybeeelsdon as a code owner October 9, 2024 22:27

marvin-serp-bot force-pushed the upgrade/nuget-restsharp-vulnerability branch from c56f43c to 976ff1a Compare October 9, 2024 23:06

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Oct 10, 2024

marvin-serp-bot closed this Oct 10, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch October 10, 2024 19:04

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Oct 10, 2024

marvin-serp-bot reopened this Oct 10, 2024

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch October 10, 2024 20:06

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Oct 12, 2024

marvin-serp-bot closed this Oct 12, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch October 12, 2024 07:04

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Oct 12, 2024

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch October 12, 2024 08:05

marvin-serp-bot reopened this Oct 12, 2024

marvin-serp-bot force-pushed the upgrade/nuget-restsharp-vulnerability branch 2 times, most recently from f4d63d2 to a21d619 Compare October 16, 2024 16:05

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Oct 17, 2024

marvin-serp-bot closed this Oct 17, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch October 17, 2024 08:07

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Oct 17, 2024

marvin-serp-bot reopened this Oct 17, 2024

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch October 17, 2024 10:06

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Oct 17, 2024

marvin-serp-bot closed this Oct 17, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch October 17, 2024 11:05

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Oct 17, 2024

marvin-serp-bot reopened this Oct 17, 2024

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch October 17, 2024 12:07

marvin-serp-bot force-pushed the upgrade/nuget-restsharp-vulnerability branch from a21d619 to 0d91023 Compare October 17, 2024 14:05

marvin-serp-bot force-pushed the upgrade/nuget-restsharp-vulnerability branch 3 times, most recently from d17db84 to a16c3bf Compare December 12, 2024 19:05

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Dec 12, 2024

marvin-serp-bot closed this Dec 12, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch December 12, 2024 21:06

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch December 12, 2024 22:06

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Dec 12, 2024

marvin-serp-bot reopened this Dec 12, 2024

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Dec 13, 2024

marvin-serp-bot closed this Dec 13, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch December 13, 2024 10:06

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Dec 13, 2024

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch December 13, 2024 13:12

marvin-serp-bot reopened this Dec 13, 2024

marvin-serp-bot force-pushed the upgrade/nuget-restsharp-vulnerability branch from a16c3bf to 22784da Compare December 13, 2024 14:06

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Dec 15, 2024

marvin-serp-bot closed this Dec 15, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch December 15, 2024 16:05

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch December 15, 2024 17:04

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Dec 15, 2024

marvin-serp-bot reopened this Dec 15, 2024

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security]~~ chore(deps): update dependency restsharp to v112 [security] - autoclosed Dec 15, 2024

marvin-serp-bot closed this Dec 15, 2024

marvin-serp-bot deleted the upgrade/nuget-restsharp-vulnerability branch December 15, 2024 23:06

marvin-serp-bot restored the upgrade/nuget-restsharp-vulnerability branch December 16, 2024 00:18

marvin-serp-bot changed the title ~~chore(deps): update dependency restsharp to v112 [security] - autoclosed~~ chore(deps): update dependency restsharp to v112 [security] Dec 16, 2024

marvin-serp-bot reopened this Dec 16, 2024

chore(deps): update dependency restsharp to v112 [security]

365934e

marvin-serp-bot force-pushed the upgrade/nuget-restsharp-vulnerability branch from 22784da to 365934e Compare January 7, 2025 13:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency restsharp to v112 [security] #863

chore(deps): update dependency restsharp to v112 [security] #863

marvin-serp-bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024

chore(deps): update dependency restsharp to v112 [security] #863

Are you sure you want to change the base?

chore(deps): update dependency restsharp to v112 [security] #863

Conversation

marvin-serp-bot commented Oct 9, 2024 • edited Loading

GitHub Vulnerability Alerts

Summary

Details

PoC

Impact

Release Notes

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

New Contributors

What's Changed

What's Changed

New Contributors

Configuration

github-actions bot commented Oct 9, 2024

✒️ PR Title Commitlint - ✔️ Lint success!

marvin-serp-bot commented Oct 9, 2024 •

edited

Loading