Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWA-97][FEAT] - Update sushiswap router and factory addresses to v3 #330

Closed
wants to merge 3 commits into from
Closed

[SWA-97][FEAT] - Update sushiswap router and factory addresses to v3 #330

wants to merge 3 commits into from

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: SWA-97

Description

  • Update Sushiswap Factory and Router deployed contracts from V2 to V3

Diogomartf
Diogomartf reviewed Jan 3, 2024
View reviewed changes
src/entities/trades/routable-platform/UniswapV2RoutablePlatform.ts Outdated
Comment on lines 23 to 25
/**
* @see https://github.com/sushiswap/v3-periphery/tree/master/deployments
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't understand this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why left the comment?

@Diogomartf
Copy link
Contributor

Diogomartf commented Jan 3, 2024 •
edited
Loading

We're publishing dist folder which usually is unintended.

If we want to have access to dist to test the SDK it should be on the description but would be better to have that on another PR.

So this one would be only the new updates and create a branch from this one with the dist folder if needed to test SDK.

@ElRodrigote
Copy link
Collaborator Author

We're publishing dist folder which usually is unintended.

If we want to have access to dist to test the SDK it should be on the description but would be better to have that on another PR.

So this one would be only the new updates and create a branch from this one with the dist folder if needed to test SDK.

Oh, I did it this way because that's how we usually do it with @berteotti , but I'm open to suggestions!

@ElRodrigote ElRodrigote requested a review from Diogomartf January 3, 2024 15:04
@ElRodrigote
Copy link
Collaborator Author

Closing this PR for now, the ticket changed to update Sushiswap V2 addresses. V3 support will be added in another issue.

@ElRodrigote ElRodrigote closed this Jan 4, 2024
@ElRodrigote ElRodrigote deleted the feat/swa-97-update-sushiswap-to-v3 branch February 1, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berteotti berteotti Awaiting requested review from berteotti

@Diogomartf Diogomartf Awaiting requested review from Diogomartf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElRodrigote @Diogomartf