Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1101]Add a features: Scan QR code from saved picture #1138

Closed

Conversation

u7505884
Copy link

@u7505884 u7505884 commented Oct 16, 2023

Description

Fixes:
The issue poster said that when tapping the scan qr code button there is no "select image" option, nothing but only the camera waiting to see a qr code, so I added the "Scan from the saved image" button. Users can select the images they want to scan from the album.

image image

If there are no images in the album,

image
image
image
image

If there are images, but no QR code on it

image
image
image

Fixes #1101

Type of change

Just put an x in the [] which are valid.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Oct 16, 2023

Code Climate has analyzed commit 07c234a and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@Swati4star
Copy link
Owner

thank you for your contribution, but this feature is already implemented with #1143

@Swati4star Swati4star closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan QR code from saved picture
2 participants