Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of deprecated version of node #197

Conversation

hamirmahal
Copy link
Contributor

fixes #196.

@@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v4

- name: Setup Node.js 20.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this would require a major version bump, as touched upon in #183.

Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that is only relevant for this repo, not for other users

@Swatinem Swatinem merged commit 9bdad04 into Swatinem:master May 3, 2024
22 checks passed
@hamirmahal hamirmahal deleted the fix/usage-of-action-that-uses-deprecated-version-of-node branch May 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check-dist uses deprecated Node.js 16 action
2 participants