Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add validation to connected services #341

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Panaetius
Copy link
Member

No description provided.

@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 7f5058b to 3f004bf Compare August 7, 2024 07:16
@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-conn-serv branch from b1c51a3 to 4a50714 Compare August 7, 2024 07:16
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 3f004bf to f43c168 Compare August 7, 2024 08:25
@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-conn-serv branch from 4a50714 to 28c2dc8 Compare August 7, 2024 08:25
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from f43c168 to 58417b0 Compare August 7, 2024 08:41
@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-conn-serv branch from 28c2dc8 to 00054af Compare August 7, 2024 08:41
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from 58417b0 to bd2b8e3 Compare August 7, 2024 12:53
@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-conn-serv branch from 00054af to 2ed2828 Compare August 7, 2024 12:53
@Panaetius Panaetius force-pushed the refactor-add-validation-to-crc branch from bd2b8e3 to b0a6da0 Compare August 7, 2024 13:24
@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-conn-serv branch from 2ed2828 to adaeb12 Compare August 7, 2024 13:24
@Panaetius Panaetius marked this pull request as ready for review August 7, 2024 13:25
@Panaetius Panaetius requested a review from a team as a code owner August 7, 2024 13:25
olevski
olevski previously approved these changes Aug 12, 2024
Base automatically changed from refactor-add-validation-to-crc to main August 12, 2024 09:44
@Panaetius Panaetius dismissed olevski’s stale review August 12, 2024 09:44

The base branch was changed.

@Panaetius Panaetius force-pushed the refactor/304-add-validation-to-conn-serv branch from adaeb12 to 8f28e34 Compare August 12, 2024 09:44
@Panaetius Panaetius requested a review from olevski August 12, 2024 09:45
@Panaetius Panaetius enabled auto-merge (squash) August 12, 2024 09:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10349564988

Details

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.446%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/connected_services/blueprints.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/db.py 1 87.58%
components/renku_data_services/storage/blueprints.py 1 94.65%
components/renku_data_services/users/db.py 1 94.14%
components/renku_data_services/secrets/db.py 3 93.07%
Totals Coverage Status
Change from base Build 10349558925: 0.02%
Covered Lines: 9060
Relevant Lines: 10017

💛 - Coveralls

@Panaetius Panaetius merged commit bede2f3 into main Aug 12, 2024
14 checks passed
@Panaetius Panaetius deleted the refactor/304-add-validation-to-conn-serv branch August 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants