-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new apispec for the new amalthea sessions #360
feat: add new apispec for the new amalthea sessions #360
Conversation
Pull Request Test Coverage Report for Build 10709956586Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API specification looks good overall. Aside from my comment below, it handles all the cases currently used for Renku 2.0.
- project_id | ||
- launcher_id | ||
type: object | ||
SessionResponse: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which part here represents the sessionId?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the name
field.
This change is part of the following stack: Change managed by git-spice. |
5a4dfa2
to
a4f95d8
Compare
a4f95d8
to
3da7dc0
Compare
@andre-code I have addressed all your comments. The other change in addition to the changes from your comments is that now the status is simpler as we discussed during the status update yesterday. Now all you get to track progress is the number of total containers and the number of ready containers. Please note that once a session is created the total number of containers may be zero for the first few request as the session is getting created and things are being created. But after 1 or 2 requests the number will be good. I can fix this it just requires a bit more changes on the amalthea side. |
3da7dc0
to
a4f95d8
Compare
a4f95d8
to
3da7dc0
Compare
3da7dc0
to
ea7da1f
Compare
This will be used only in Renku v2 with the new Amalthea operator.
ea7da1f
to
5d7e340
Compare
This will be used only in Renku v2 with the new Amalthea operator.