Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new apispec for the new amalthea sessions #360

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 20, 2024

This will be used only in Renku v2 with the new Amalthea operator.

@olevski olevski requested a review from a team as a code owner August 20, 2024 15:21
@olevski olevski requested a review from andre-code August 20, 2024 15:21
@coveralls
Copy link

coveralls commented Aug 20, 2024

Pull Request Test Coverage Report for Build 10709956586

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.572%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_models/core.py 1 91.4%
components/renku_data_services/connected_services/db.py 1 82.18%
components/renku_data_services/crc/db.py 1 87.81%
components/renku_data_services/storage/blueprints.py 1 94.76%
components/renku_data_services/crc/blueprints.py 3 93.19%
Totals Coverage Status
Change from base Build 10701549852: -0.02%
Covered Lines: 9290
Relevant Lines: 10257

💛 - Coveralls

Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API specification looks good overall. Aside from my comment below, it handles all the cases currently used for Renku 2.0.

components/renku_data_services/notebooks/api.spec.yaml Outdated Show resolved Hide resolved
- project_id
- launcher_id
type: object
SessionResponse:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part here represents the sessionId?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name field.

@olevski
Copy link
Member Author

olevski commented Aug 28, 2024

@andre-code I have addressed all your comments. The other change in addition to the changes from your comments is that now the status is simpler as we discussed during the status update yesterday.

Now all you get to track progress is the number of total containers and the number of ready containers.

Please note that once a session is created the total number of containers may be zero for the first few request as the session is getting created and things are being created. But after 1 or 2 requests the number will be good. I can fix this it just requires a bit more changes on the amalthea side.

This will be used only in Renku v2 with the new Amalthea operator.
@olevski olevski force-pushed the feat-add-new-sessions-apispec branch from ea7da1f to 5d7e340 Compare September 20, 2024 08:55
@olevski olevski changed the base branch from main to release-amaltheas-migration September 20, 2024 09:07
@olevski olevski merged commit b3a4da7 into release-amaltheas-migration Sep 20, 2024
19 checks passed
@olevski olevski deleted the feat-add-new-sessions-apispec branch September 20, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants