Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): fix cache not getting refreshed #3657

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

Panaetius
Copy link
Member

the walrus library does not store None, but turns it into empty string, which would always fail the check.

@Panaetius Panaetius requested a review from a team as a code owner November 21, 2023 16:22
@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6946727366

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1014 unchanged lines in 84 files lost coverage.
  • Overall coverage decreased (-3.3%) to 82.73%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/gateways/repository_cache.py 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/core/dataset/providers/renku.py 1 86.69%
renku/core/image.py 1 97.14%
renku/core/init.py 1 92.86%
renku/core/migration/migrate.py 1 82.14%
renku/core/template/usecase.py 1 89.71%
renku/domain_model/provenance/agent.py 1 81.72%
renku/domain_model/template.py 1 90.43%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
Totals Coverage Status
Change from base Build 6929940137: -3.3%
Covered Lines: 25508
Relevant Lines: 30833

💛 - Coveralls

@Panaetius Panaetius enabled auto-merge (squash) November 21, 2023 16:29
@Panaetius Panaetius merged commit 130c21d into develop Nov 21, 2023
@Panaetius Panaetius deleted the fix-svc-cache branch November 21, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants