-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi-hop RAG opt + improvement] [V0.3.0 Cycle Graph] #223
Conversation
…api_kwargs for generator/retriever for debug in the parameter and to visualize in the graph in the parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @liyin2015, Is this PR ready to be reviewed?
…currently only works on one llm call
…ponent, now diagnose works for complicated multi-hop rag
…sively, add ScoreTrace as a structure to support multi_eval function
… score is correct at the demo parameter, need to check demo optimizer
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…esponse at least it is better than not having value especially be careful with None
… on multi-hop rag, from 0.58 to 0.68, still 6% lower than few shot learning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: write a better relase change log later
Design choice: (1) support cycle, we treat it as a component where its prompt has to be adapted to multiple sets of inputs and outputs, in practical this make sense (2) user not creating a cycle, they treating each repeating as a new copy node and has its own parameter.
For (2) its easy, everything works out of box, users just need to know that they are doing this intentional
for (1) we have to carefully design how the gradient works, and how the demo works (demo should aggregate both parts)
Multi-hop retriever
Multi-hop RAG (works by simplify replace the retriever if we simplify follow the retriever api)