Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adalflow model client notebook tutorial #260

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

ajithvcoder
Copy link
Contributor

Added a new notebook for modelclient tutorial based on following issues

#194
#123

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ajithvcoder
Copy link
Contributor Author

@Sylph-AI let me know if its fine

@ajithvcoder
Copy link
Contributor Author

@liyin2015 i read pull request 261 , i need to add .py files other than that any changes needed ?

Copy link
Collaborator

@fm1320 fm1320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, can you also add the relevant links in the docs/source/tutorials .rst files so that the notebook can be part of the documentation page. More info also here: https://adalflow.sylph.ai/contributor/contribution.html
But basically we want to have the links "Open in colab" clickable on the top of the page like here:
Screenshot 2024-11-21 at 01 02 58

@liyin2015
Copy link
Member

@fm1320 please merge and update the links later ourselves

@liyin2015 liyin2015 added the P0 Highest priority label Nov 25, 2024
@ajithvcoder
Copy link
Contributor Author

@liyin2015 In case if there is time, i will complete it by 26-11-2024 17:00 IST

@ajithvcoder ajithvcoder requested a review from fm1320 November 26, 2024 07:32
@ajithvcoder
Copy link
Contributor Author

@fm1320

I have done following changes

  1. Added links in colab file
  2. Added links in .rst file docs/source/tutorials /model_client.rst
  3. Updated additional codes from notebook related to model_client in .rst file

@fm1320
Copy link
Collaborator

fm1320 commented Nov 26, 2024

@fm1320

I have done following changes

  1. Added links in colab file
  2. Added links in .rst file docs/source/tutorials /model_client.rst
  3. Updated additional codes from notebook related to model_client in .rst file

Looks good just ran pre-commit hooks to ensure format

@fm1320 fm1320 merged commit fc18aa2 into SylphAI-Inc:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants