-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multimodal #319
base: main
Are you sure you want to change the base?
Fix multimodal #319
Conversation
a71bf37
to
922681a
Compare
@@ -229,7 +231,7 @@ def convert_inputs_to_api_kwargs( | |||
self, | |||
input: Optional[Any] = None, | |||
model_kwargs: Dict = {}, | |||
model_type: ModelType = ModelType.UNDEFINED, | |||
model_type: ModelType = ModelType.UNDEFINED, # Now required in practice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please default to LLM
response = self.sync_client.images.edit(**api_kwargs) | ||
else: | ||
# Image variation | ||
elif operation == "variation": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create_variation
response = await self.async_client.images.edit(**api_kwargs) | ||
elif operation == "variation": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create_variation
@@ -100,6 +91,7 @@ def __init__( | |||
# args for the cache | |||
cache_path: Optional[str] = None, | |||
use_cache: bool = False, | |||
model_type: ModelType = ModelType.LLM, # Add model_type parameter with default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont update it here, let it be controled in the model client
@@ -133,6 +124,7 @@ def __init__( | |||
CallbackManager.__init__(self) | |||
|
|||
self.name = name or self.__class__.__name__ | |||
self.model_type = model_type # Use the passed model_type instead of getting from client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this
What does this PR do?
Fixes #<issue_number>
Before submitting