Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dryrun device not found & fedyogi argument order #235

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

EricDinging
Copy link
Contributor

@EricDinging EricDinging commented Sep 5, 2023

@fanlai0990

Why are these changes needed?

In dry_run, device is not in the config, and an error will be thrown in customize_client.py. Add logic to infer device from use_cuda field.

Related issue number

Closes #233
Closes #232

Checks

  • I've included any doc changes needed for https://fedscale.readthedocs.io/en/latest/
  • I've made sure the following tests are passing.
  • Testing Configurations
    • Dry Run (20 training rounds & 1 evaluation round)
    • Cifar 10 (20 training rounds & 1 evaluation round)
    • Femnist (20 training rounds & 1 evaluation round)

@EricDinging EricDinging closed this Sep 5, 2023
@EricDinging EricDinging reopened this Sep 5, 2023
@EricDinging EricDinging changed the title Fix dryrun Fix dryrun device not found & fedyogi argument order Sep 5, 2023
@AmberLJC
Copy link
Member

AmberLJC commented Sep 5, 2023

Thanks for your effort!
I will merge for now, Eric will report the updated time-accuracy later.

@fanlai0990 fanlai0990 merged commit faab283 into SymbioticLab:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[customized_client] No attribute name device
3 participants