Handle Sass cli options (style, --no-source_map, --embed-sources...)

[smnandre]

Update:

the following options are handled

// Input and Output
'--style' => 'expanded',                // Output style.  [expanded (default), compressed]
'--[no-]charset' => null,               // Emit a @charset or BOM for CSS with non-ASCII characters.
'--[no-]error-css' => null,             // Emit a CSS file when an error occurs.
// Source Maps
'--[no-]source-map' => true,            // Whether to generate source maps. (defaults to on)
'--[no-]embed-sources' => null,         // Embed source file contents in source maps.
'--[no-]embed-source-map' => null,      // Embed source map contents in CSS.
// Warnings
'--[no-]quiet' => null,                 // Don't print warnings.
'--[no-]quiet-deps' => null,            // Don't print deprecation warnings for dependencies.
// Other
'--[no-]stop-on-error' => null,         // Don't compile more files once an error is encountered.
'--[no-]trace' => null,                 // Print full Dart stack traces for exceptions.

---

Been playing with this bundle a bit so ... .. is this as you imagined it ?

I just took some options to start the work:

charset
style
source_map
embed_source_map
embed_sources

We can implement more after: https://sass-lang.com/documentation/cli/dart-sass/#no-source-map

I tried something else at first, so maybe the DTO is not really usefull

Tell me :)

[smnandre]

I reworked that and followed @stof feedback

Open to any comment / suggestions :)

[smnandre]

How would you like to advance on this topic ?

[bocharsky-bw]

Sorry for the delay!

Yeah, it seems like this one is ready for me, I don't have much to add, though hoped to hear some other opinions on it

[smnandre]

I'm reworking this PR (just a bit) to make the options more obvious for everyone, maybe tonight, tomorrow elsewhen.

[smnandre]

So, i reworked how the options are handled in what i personnaly find is more simple to handle.

1. I removed the default values from the dependency injection / configuration
2. The management of the [no] is internal in the Builder and - i find - more easy to manage / understand.

The 2 option format (php in snake case, CLI in --[no-]dashed) are mapped in the builder

I'd just need some help to add some of the missing tests (deps, errors, ...) .. or if you can wait a bit, i will have time in a couple of days.

[bocharsky-bw]

Thanks! No rush at all, we can definitely wait 👍

[smnandre]

That feels OK for me.. open to any feedback!

And if anyone wants to check on its side please do, i don't have any big sass project on my radar right now to fully test "live"

[bocharsky-bw]

Hey Simon!

Thank you for rewriting it! It seems more solid now, so I think it's ready 👍

[smnandre]

I have no idea how you'd imagine the documentation so feel free to tell me if what i added is not in the spirit of this Bundle :)

[bocharsky-bw]

About the docs - list all the possible options is just fine for me

[smnandre]

Hmm something has no worked / i messed my push ...

--watch should be the option and "true" the value

[smnandre]

It is

...$this->getBuildOptions(['--watch' => $watch]),

I'm not sure if something happened with the git log (possible as i have this bad habit to destroy git histories on a daily basis 🤒 )

or maybe github did not show you the "flatten" changes ?

[bocharsky-bw]

Ah, it might be so that I just missed it... or reviewed not full change set. Makes sense to me now! 👍

OK, I think we're completely ready here, thank you for your work on it!

[smnandre]

It's been a pleasure... 😄

But don't thank me too soon, we'll see how many complaints/bugs you'll receive haha

[bocharsky-bw]

Well, I'm glad you're somewhere around... 😅