Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of big media directories (#694) #699

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Improve handling of big media directories (#694) #699

merged 3 commits into from
Nov 18, 2024

Conversation

Et0h
Copy link
Contributor

@Et0h Et0h commented Oct 7, 2024

As a result of #694 I am have made the following tweaks to how Syncplay handles media directory scanning:

  1. Only scan directories and sub-folders in the relevant thread. This means that if you try to load a file via the playlist before this occurs it may fail temporarily, but it does not check if the file of that name is in the media directory (it just does not check sub-folders).
  2. It now provides a warning after 2 seconds of not loading, with a further warning every second.
  3. Warnings and errors for media directory now state the number of files scanned so far and explicitly states a larger number of files in the folder can also slow things down.

@Et0h Et0h merged commit dd3884b into master Nov 18, 2024
4 of 6 checks passed
@Et0h Et0h deleted the fixMediaDirs branch November 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant