Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addition of bubble sort, merge sort, quick sort and selection sort in C++ #16

Merged
merged 2 commits into from
Oct 17, 2021
Merged

addition of bubble sort, merge sort, quick sort and selection sort in C++ #16

merged 2 commits into from
Oct 17, 2021

Conversation

AyushhS
Copy link
Contributor

@AyushhS AyushhS commented Oct 16, 2021 •
edited
Loading

Description

Adding bubble sort, merge sort, quick sort and selection sort algorithms in C++

Have you read the Contributing Guidelines on Pull Requests?

Yes

Please answer the following questions for yourself before submitting an issue.

  • I've read the contribution guidelines.
  • I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests

link to the issue

@AyushhS AyushhS changed the title addition of bubble sort, merge sort, quick sort and selection sort in… addition of bubble sort, merge sort, quick sort and selection sort in C++ Oct 16, 2021
ag278
ag278 reviewed Oct 16, 2021
View reviewed changes
Copy link
Collaborator

@ag278 ag278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the end of each file, add a sample test case along with its output in the comments

@ag278 ag278 self-requested a review October 16, 2021 17:24
@AyushhS
Copy link
Contributor Author

AyushhS commented Oct 17, 2021

Ok! Ill do that

@AyushhS
Copy link
Contributor Author

AyushhS commented Oct 17, 2021

please review the changes @ag278

Rj-coder-iitian
Rj-coder-iitian approved these changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@Rj-coder-iitian Rj-coder-iitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

ag278
ag278 approved these changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@ag278 ag278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Able to merge

@ag278 ag278 merged commit 63ecbb4 into Synergise-IIT-Bhubaneswar:main Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag278 ag278 ag278 approved these changes

@Rj-coder-iitian Rj-coder-iitian Rj-coder-iitian approved these changes

Assignees
No one assigned
Labels
syn-accepted syn-easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AyushhS @Rj-coder-iitian @ag278