Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to 0.6 :) #70

Merged
merged 4 commits into from
Jan 27, 2024
Merged

Conversation

rakshith-ravi
Copy link
Contributor

No description provided.

@rakshith-ravi
Copy link
Contributor Author

Oh FML! Actix hasn't upgraded to http 1 yet. Great

@rakshith-ravi
Copy link
Contributor Author

I HATE the hacky workaround I'm doing, but whatever. Let me know if this fine

@rakshith-ravi
Copy link
Contributor Author

@maccesch that testing problem we discussed about is popping up here. And actix isn't willing to upgrade to http1 until 0.5 (actix/actix-web#3208 (comment)) so we're gonna have to do a workaround till then

@maccesch maccesch merged commit 352203b into Synphonyte:main Jan 27, 2024
0 of 2 checks passed
@maccesch
Copy link
Contributor

Thanks! I didn't even know that you can specify dependencies like that. Looks good to me. Once Actix updates we can simplify but until then I think this is a good solution.

@rakshith-ravi rakshith-ravi deleted the feature/version-upgrade branch January 27, 2024 11:51
@rakshith-ravi
Copy link
Contributor Author

Wait, so how are we gonna make a new release with the tests failing?

@rakshith-ravi
Copy link
Contributor Author

Thanks for that write up!

Yes, this has already been discussed with @maccesch and I in a private DM. These were the approaches we had in mind, the question was more of "what's the plan to make a release with a failing build" rather than "how do we solve this". We have a few solutions in mind that would mitigate this in the future, so this is just for a temporary workaround we need to do till actix 5 releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants