Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for when GH_TOKEN is not set #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for when GH_TOKEN is not set #42

wants to merge 1 commit into from

Conversation

berquist
Copy link

The exception was never being thrown because GH_TOKEN was never None.

Accidentally introduced in 10e0f25.

Accidentally introduced in 10e0f25
@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files           5        5           
  Lines         138      138           
=======================================
  Hits          113      113           
  Misses         25       25
Impacted Files Coverage Δ
travis_sphinx/deploy.py 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1082606...8219419. Read the comment docs.

@Syntaf
Copy link
Owner

Syntaf commented Jul 15, 2018

Thanks for the typo fix, but why are you removing the default value of '' for the env variable? What would we gain from having a null instead of an empty string?

@berquist
Copy link
Author

The empty string does not properly trigger this line, which leads to falling through to the message "Deploy triggered for non-master branch 'master': skipping deploy" and having the deploy return as successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants