Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add renameAccount method #1084

Closed
wants to merge 12 commits into from

Conversation

0xSero
Copy link
Contributor

@0xSero 0xSero commented Jan 25, 2024

Motivation and context

Renaming wallets is important for managing financials

Clearly and concisely describe the feature added/isses being solved.

Does it fix any issue?

Adds functionality that isn't currently available in new dawn

#(issue)

Other useful info

N/A

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 2:05pm

@0xSero 0xSero marked this pull request as ready for review January 25, 2024 14:22
@duckception
Copy link
Contributor

Hey! Thanks for the PR! 🖤

It's perfect except for a few super small details 😇

@0xSero 0xSero force-pushed the sero/rename-account branch from 1a13113 to 02b591d Compare February 1, 2024 18:40
Copy link

vercel bot commented Feb 1, 2024

@Seroxdesign is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.

@0xSero
Copy link
Contributor Author

0xSero commented Feb 2, 2024

Hey! Thanks for the PR! 🖤

It's perfect except for a few super small details 😇

Thanks for taking the time to review, I pushed up a few changes that should make this more stable, specifically i removed the validation, made it so that I use a mouse click instead of an enter key, and removed a test spec I wrote for the English reserved names.

Good catches btw

@0xSero 0xSero changed the title Rename Account functionality ✨ feat(metamask): Add support for renaming account Feb 3, 2024
@0xSero 0xSero changed the title ✨ feat(metamask): Add support for renaming account ✨ feat(metamask): Add renameAccount method Feb 5, 2024
@0xSero 0xSero changed the title ✨ feat(metamask): Add renameAccount method ✨ feat(metamask): Add renameAccount method Feb 5, 2024
@0xSero 0xSero force-pushed the sero/rename-account branch from e31b2c9 to 7a3353b Compare February 5, 2024 09:36
@0xSero
Copy link
Contributor Author

0xSero commented Feb 8, 2024

I ran lint and redid the title, hopefully this is ready to go (:

@duckception
Copy link
Contributor

@drptbl Can you handle this? Looks decent 👍

@0xSero 0xSero changed the title ✨ feat(metamask): Add renameAccount method ✨ feat: Add renameAccount method Feb 12, 2024
@0xSero
Copy link
Contributor Author

0xSero commented Feb 12, 2024

@drptbl can you please rerun this Validate Title check?
Last one should've been valid, not sure why it failed. Any idea?

@0xSero
Copy link
Contributor Author

0xSero commented Mar 11, 2024

@duckception @drptbl either of you able to get this merged?
The naming convention is being followed from what I understand but if not lmk what i'm doing wrong.

@0xSero 0xSero closed this Jun 11, 2024
@0xSero 0xSero deleted the sero/rename-account branch June 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants