Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LRSchedulerWrapper with shared memory address issue. #135

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Fix LRSchedulerWrapper with shared memory address issue. #135

merged 5 commits into from
Apr 10, 2024

Conversation

RoyYang0714
Copy link
Collaborator

@RoyYang0714 RoyYang0714 commented Jan 10, 2024 •
edited
Loading

This PR aims to fix the LRScheduleWrapper with the shared memory address.

  • Copy and resolve reference the reference for the lr scheduler config.

@RoyYang0714 RoyYang0714 marked this pull request as ready for review April 10, 2024 13:38
thomasehuang
thomasehuang approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@thomasehuang thomasehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing all the lint and mypy issues :)

@thomasehuang thomasehuang merged commit b25086f into main Apr 10, 2024
2 checks passed
@thomasehuang thomasehuang deleted the fix-warmup branch April 10, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasehuang thomasehuang thomasehuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyYang0714 @thomasehuang