Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] interview layout + videocard modal fix #164

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

moony1204
Copy link
Contributor

작성자: @moony1204
이슈: #135

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 상단에 이슈 번호를 기입했나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • 인터뷰 레이아웃 변경 (min size 350으로 키움)
  • 로그인 되지 않았을 때 북마크, 퀴즈 풀기 실행 안되게 팝업 띄움
  • 퀴즈 호출과 제출 관련 error 상황 시 팝업 띄움
  • 비디오카드를 눌렀을 때 상세보기 모달이 뜨도록 코드 수정

비고

  • 노퀴즈도 수정 해야 함 ..

@moony1204 moony1204 added the fix label Feb 5, 2025
@moony1204 moony1204 self-assigned this Feb 5, 2025
@moony1204 moony1204 requested a review from 2tle February 5, 2025 04:26
Copy link
Contributor

@2tle 2tle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

고생하셨습니다!!

@moony1204 moony1204 merged commit 34a129f into develop Feb 5, 2025
1 check failed
@moony1204 moony1204 deleted the fix/135-videocard branch February 5, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants