Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 버튼 추가 #24

Merged
merged 4 commits into from
Aug 8, 2024
Merged

[FEAT] 버튼 추가 #24

merged 4 commits into from
Aug 8, 2024

Conversation

sera2222
Copy link
Contributor

작성자: @sera2002
이슈: #8

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 상단에 이슈 번호를 기입했나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • secondary button, outlined button, danger button을 추가하였습니다.
  • primary button의 스타일을 수정하였습니다.

비고

  • 참고 사항을 적어주세요. 코드 리뷰하는 사람이 참고해야 하는 내용을 자유로운 형식으로 적을 수 있습니다.

close/resolve/fix #{이슈 번호 기입}

@sera2222 sera2222 added the feat label Jul 19, 2024
@sera2222 sera2222 self-assigned this Jul 19, 2024
Copy link

Copy link
Contributor

@obinox obinox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제없는 것 같습니다

@sera2222 sera2222 changed the title [Feat] 버튼 추가 [FEAT] 버튼 추가 Jul 26, 2024
@chunzhi23 chunzhi23 self-requested a review July 27, 2024 07:51
Copy link
Contributor

@chunzhi23 chunzhi23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 개인적인 생각으로 disabled의 경우 회색 톤의 살짝 흐려지는 느낌이 좋을 것 같다고 느끼는데 추후 논의를 거쳐서 확정지으면 좋을 것 같습니다!

Copy link

github-actions bot commented Aug 7, 2024

@sera2222 sera2222 merged commit b918e68 into develop Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants