Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-6 Add arcgis & wms layer support #209

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

shayanaijaz
Copy link
Contributor

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Added support for wms layer using WMSTileLayer from react-leaflet library
  • Added support for arcgis layer using TiledMapLayer from react-esri-leaflet library
  • Added data to tileServerLayers fixture with arcgis and wms layers

Testing Steps:

  1. Run hazmapper locally and navigate to localhost:4200/project
  2. Ensure that the map and the argis layers render
    Note: The layer is hard to see due to lack of layer functionality in the react map. A screenshot below shows where to zoom in to be able to see the layers

UI Photos:

Screen Shot 2024-02-12 at 1 10 00 PM Screen Shot 2024-02-12 at 1 10 18 PM Screen Shot 2024-02-12 at 1 10 58 PM

@shayanaijaz shayanaijaz marked this pull request as ready for review February 14, 2024 17:21
Copy link
Contributor

@tjgrafft tjgrafft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reviewed code and tested locally. I got a bunch of 404 errors in my console when it was trying to grab the various arcgis tile layers from the urls in the fixtures--but after discussing with Shayan offline, these 404 resource-not-found errors are present in prod too (same arcgis layers are used here https://hazmapper.tacc.utexas.edu/hazmapper/project-public/a1e0eb3a-8db7-4b2a-8412-80213841570b) so probably just a bad/old url the fixtures are using and/or the resource locations have moved.

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shayanaijaz shayanaijaz merged commit 821879a into master Feb 22, 2024
5 checks passed
@shayanaijaz shayanaijaz deleted the task/WG-6--arcgis-wms-layers branch February 22, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants