task/WG-240: Tile Layers Panel #304
Conversation
* Update params with analytics_params * Use const now for url
rstijerina
requested review from
nathanfranklin,
shayanaijaz and
sophia-massie
rstijerina
force-pushed
the
task/WG-240--tile-layers-panel
branch
from
c83faeb to
ba9a503
Compare
| const isAuthenticated = useSelector((state: RootState) => | ||
| isTokenValid(state.auth.authToken) | ||
| ); | ||
| const canSaveForm = isAuthenticated && !isPublicView; |
There was a problem hiding this comment.
no need to change but you could simplify to const canSaveForm = isAuthenticated. only authed users can see a private map (!isPublicView ); handled here: https://github.com/TACC-Cloud/hazmapper/blob/main/react/src/AppRouter.tsx#L60-L65
There was a problem hiding this comment.
Is it correct to say that authed users cannot see a public view?
There was a problem hiding this comment.
authed users or unauthed users can see a public view (project-public/{uuid}) while auth is required for the "private" route of project/{uuid}.
Ugh, i see i miswrote my comment. 🫤 i meant to write
const canSaveForm = !isPublicView;
| return ( | ||
| <Layout {...props}> | ||
| <Flex vertical className={styles.root}> | ||
| <Header className={styles.header}>{panelTitle}</Header> |
There was a problem hiding this comment.
in Feb, should we look at making the header take up smaller space?
There was a problem hiding this comment.
What size were you thinking?
There was a problem hiding this comment.
just slightly smaller text and then less empty space. but just my thoughts; looks good as is 👍
There was a problem hiding this comment.
I'm seeing a bug where if you change the layers but don't click save, back out of the project map, and come back. It breaks the map.
I change the layers here, wanted them to reset to what they were, when to home page, and went back to the map. Now it won't load. After about 2 min, the map resets and the project loads again.
Overview:
<Layout>from antdPR Status:
Related Jira tickets:
Testing Steps:
UI Photos:
Notes:
TODO: